XF\Mvc\Router::prepareStringForUrl contains tiny amount of uneeded code

Status: This content is read-only, or is not open for further replies.

Steffen

Guest

offline

OP
Oct 24, 2024
0
145

There are no double quotes left after the immediately preceeding strtr call (not completely visible in the diff below) which replaces double quotes with a space character.

Diff:

Code:

--- a/src/XF/Mvc/Router.php
+++ b/src/XF/Mvc/Router.php
@@ -581,7 +581,7 @@ class Router
            '`!"$%^&*()-+={}[]<>;:@#~,./?|' . "\r\n\t\\",
            '                             ' . '    '
        );
-       $string = strtr($string, ['"' => '', "'" => '']);
+       $string = strtr($string, ["'" =>...