Webhook criteria are not easily composable

Status
This content is read-only, or is not open for further replies.

Xon

Guest
offline
When implementing additional criteria, XF exposes the method XF\Webhook\Event\AbstractHandler::getCriteriaClass.

The problem is if XF doesn't implement one, it returns null. So if a 3rd party add-on implements it, it will override any other 3rd party criteria class and any future XF criteria.

IE implementing XF\Webhook\Event\PostHandler::getCriteriaClass will override any future post criteria.

I think the better solution would be for XF to implement a base criteria...

Read more

Continue reading...
 
Liked by:
Status
This content is read-only, or is not open for further replies.
Top Bottom