MC Plugin PyroFishingPro [1.14.X -1.20.X] [#1 Fishing Plugin!] [NEW Tournament Rework] 4.9.1

Is fishing boring? Do you want loads of custom and unique features? This is the plugin for you!

Requires PyroLib v1.4 or higher to run.

Apologies for the delay on this - I've been trying to find the root cause of the problem with recipes being set to 1x items - which has now been resolved.

No configuration changes are required for this update.

Additions:
- Added a fall over number check that will revert slots to their default value if they are not detected. (This should prevent the “fishing rod is invalid” message and rods from being deleted in the future, assuming you are using the default menu configuration for the rod and augment slots).

General Changes:
- Mythical waters will no longer activate on Platinum and Mythical fish. (they never got upscaled so this just removes confusion).
- Nerfed Divine Judgement spawn chance, but increased the duration.

Fixes:
- Fixed an issue with augment recipes numbers always showing as 1.
- Fixed some augment messages not being shown correctly.
- Fixed model data not working with augments.
- Fixed some minor issues in various places in the Augment System.

If you are a server owner, please check the General Changes section regardless if you will be using the rework system.

Additions:
- Added a check that prevents tournament types from running back-to-back if there is more than 1 configured type.
- Added the new augment system. This is now NBT based, and is more efficient, and allows for more customisbility in the future. [Note: Adding lore still works on fresh rods, and this is to allow for old rods to be converted over. This feature will be removed in a future update to block all lore-based attempts. Players have to use their fishing rods once for it to convert automatically.]
- Added the Apply Augment and Augment List as configurable menus.
- Added special/seasonal augments to the Augment List menu.
- Added the ability to configure the augment lore.
- Added new sections to augment lores that shows if an augment is a seasonal augment, and where to get it from, and if it is craftable. (this will be used more in the future).
- Added the ‘all’ sub-command to ‘/fish removedelivery’ (i.e. /fish removedelivery all)

General Changes:
- Made massive optimisations to the entire augment system.
- Changed the /fish giveaugment command to use proper enum names. This means that commands using the old names may no longer work as expected.
- Changed most augment descriptions to be more simpler and shorter.
- Improved the help books in the apply augment menu and the augment list menu.
- Included instructions on how to craft augments on bedrock into the augment list menu.
- When removing augments, they will now attempt to be added to your inventory instead of dropping on the ground.
- Changed a lot of the messages and moved them around to make it easier to navigate the messages.yml. (you may need to redo some of the messages).
- Removed some messages that are no longer in use.

Fixes:
- Fixed an issue with the start date for Crabmas returning the end date instead. (not an issue since the event has already ended).
- Fixed some augment descriptions being slightly incorrect.
- Fixed an issue where augments could be taken out of the augment list menu.

Additions:
- Added 90% of the augment rework in. It will be ready for release very soon.

General Changes:
- Crabmas has been extended until 11th of January.
- Crabmas will now start on the 12th of December instead of the 21st.
- Crabmas will now end on the 1st of Janaury the preceeding year.

Fixes:
- Fixed the Crabmas Event ending early due to the year change. This should now be fixed for subsequent years going forward.

Fixes:
- Fixed the /fish stats menu not displaying data correctly for online-players when using MySQL.
- Fixed an issue with MySQL when the plugin disables.

Additions:
- Added more settings to the ‘DisabledWorlds’ function. This will now disable the entire fish command, and opening the menu through shift-clicking.
- Added new API Event ‘PyroFishCatchEvent’. (an extensive API is in the works but will take a while before its completed. This is a temporary addition until that is completed).

General Changes:
- Removed legacy Tornado augment.
- Removed legacy code that supported Tsunami.
- [Optimisation] Removed duplicate method calls in some areas.

Fixes:
- Fixed the new scaling weight function sometimes returning a negative weight value.
- Fixed a major issue with the “/fish give” command.
- Fixed an issue with fish augments.
- Fixed an issue with tournament placeholders in reward commands.
- Fixed an issue with the new menu customisation builder.
- Fixed an issue with Start/Stop tournament commands.
- Fixed a possible issue with Divine Judgement.
- Fixed the config permission node for the Bait Shop not working.
- Fixed an issue with placing totems and it not cancelling events correctly.

Additions:
- Added a new “DisableAllFishing” config option that prevents any type of fishing. (Mainly for when major exploits arise).
- Added a new “FishExploitKicker” that will kick players if they trigger a certain type of exploit.

General Changes:
- Fish that have been scaled, will now have their weight set based on the price increase/decrease.
- The Scaling feature can now change prices more randomly.

Fixes:
- Fixed a possible issue with the fish totem particles not ending properly.
- Fixed a bug in the fish scales where clicking on “Medium” would update the “Low” lore to be identicial to the medium one and not the low one.

Fixes:
- Fixed an issue relating to deliveries on new setups.
- Fixed an on-going issue with tournament times being unaligned on a 24 hour clock.

Additions:
- Added a new MySQL option to configure the load delay before loading player data. This may help in some-cases where data doesn’t have enough time to save.
- Added tab completion to the /fish stats command.
- Added the ability to shift-click with entropy crystals to redeem the entire stack in one-go.
- Added a new setting: ‘isSellable: <boolean>’ to the fish.yml for each fish.
- Added new placeholders for the Crab Catch Commands to spawn them at the bobber location using %bobber_x/y/z%
- Added a new config option “RawFishNBT” that gives all raw fish caught from fishing only a special NBT tag, and makes it so only these special raw fish can be sold at the /fish shop.
- Added a new sorting system to tournaments to help keep track of the order players win tournaments to hopefully fix issues with ties.
- Added a new config option ‘IgnoreAugmentCraftingNBT’ to ignore NBT when crafting augments.
- Added the ability for the config option ‘ForceInventory’ to force crab, squid and dolphin drops into the players inventory as well.
- Added the ability to start and stop commands upon a tournament starting and ending.
- Added support to use chances with eating commands. Format ‘chance:number>command’
- Added support to ‘chain’ commands in a single line. Especially useful for eating commands chances. i.e. ‘<chance:50>broadcast first command,broadcast second command’

General Changes:
- Changed the data loader to be async.
- Changed some internal messages in console to be properly formatted.
- Changed the minimum length of fish from 5cm, to 0.1cm.
- Changed Starfall to be disabled by default as it’s being removed and a new passive will be put in its place soon.
- Changed Divine Judgemenet to increase by 0.04% per 15 levels from 0.01% per 20 levels.
- Changed Totems to now save data after upgrading to help prevent issues with data-loss.
- Changed ‘Crabs Killed’ Tourmanet type to only count crabs killed that have been caught by the player. Any crabs not caught by the original player do not count.
- Removed some old messages that are no longer in use from the messages.yml
- Bait will now be automatically removed from your fishing rod, if it no longer exists, or is disabled.
- Breaking the totem will now attempt to force it into your inventory, before dropping it on the ground, to reduce possible loss of items.

Fixes:
- Fixed an issue with Random Catch ending throwing an error sometimes.
- Fixed an issue where players with similar nicknames would be replaced for the player in commands, if the original player was offline.
- Fixed an issue with data saving, not properly clearing the cache on rare occassions. leading to data being loaded from cache, and not the database.
- Fixed an issue relating to MySQL connections.
- Fixed an issue with sell commands not formatting commands properly.
- Fixed a rounding error in /fish deliveries
- Fixed an issue with the delivery upgrade ‘Overclocked’ not properly working.
- Fixed an issue where you were unable to catch custom fish if the bait on your fishing rod had been removed.
- Fixed an issue where you could not remove bait from a rod, if the bait no longer existed.
- Fixed not being able to use plugman or similar plugins to reload the plugin without causing issues.
- Fixed an issue with Crab Lure’s not properly calculating their percentages if the user did not have Crab Bait on their rod. It is now calculated independently.
- Fixed being able to use lures, and crab scales to dye signs on accident.
- Fixed a small duplication exploit.

Fixes:
- Fixed an error when the plugin auto-starts tournaments and throws an error when trying to call the new API Events.
- Fixed an issue where the Crab Killing tournament would increment from fish catches.

Fixes:
- Fixed an issue with Shortest Length not properly calculating the smallest length first.
- Fixed an issue where some tournaments would incorrectly calculate the positioning order of winners, meaning whoever came first did not always come first.